Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create renderers for ElementType and subclasses #2080

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Create renderers for ElementType and subclasses #2080

merged 1 commit into from
Nov 21, 2019

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Nov 21, 2019

No description provided.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 21, 2019
jcollins-g
jcollins-g approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: I think recent changes made to returnType might make some of these redundant, e.g. you can always use returnType.name instead of switching between them. I haven't followed all the code through though and we can always make that improvement down the road.

@jdkoren jdkoren merged commit 526fc4e into dart-lang:master Nov 21, 2019
@jcollins-g jcollins-g mentioned this pull request Dec 5, 2019
Closed
@jdkoren jdkoren deleted the element_type branch January 7, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdkoren @jcollins-g @googlebot